Skip to content

Reset scale of exponential histogram #6557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Reset scale of exponential histogram #6557

wants to merge 14 commits into from
+21 −10

Conversation

hannahhaering
Copy link
Contributor

@hannahhaering hannahhaering commented Oct 2, 2025 •
edited
Loading

Fixes #5635

Changes

Reset scale to 20 of the Base2 Exponential Bucket Histogram after each collection cycle when using delta aggregation temporality.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@hannahhaering hannahhaering marked this pull request as ready for review October 2, 2025 02:35
@hannahhaering hannahhaering requested a review from a team as a code owner October 2, 2025 02:35
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Oct 2, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.69%. Comparing base (0ea6c23) to head (093f6e4).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6557      +/-   ##
==========================================
+ Coverage   86.67%   86.69%   +0.01%     
==========================================
  Files         258      258              
  Lines       11895    11896       +1     
==========================================
+ Hits        10310    10313       +3     
+ Misses       1585     1583       -2
Flag Coverage Δ
unittests-Project-Experimental 86.27% <100.00%> (-0.31%) ⬇️
unittests-Project-Stable 86.64% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ics/MetricPoint/Base2ExponentialBucketHistogram.cs 100.00% <100.00%> (ø)
...c/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs 94.17% <100.00%> (-0.07%) ⬇️

... and 2 files with indirect coverage changes

martincostello
martincostello reviewed Oct 2, 2025
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Please update the CHANGELOG.

martincostello
martincostello reviewed Oct 7, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

@Kielek Kielek Kielek left review comments

Assignees
No one assigned
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base2 Exponential Bucket Histogram should reset to scale 20 after each collection cycle if DELTA aggregation temporality is used
3 participants
@hannahhaering @martincostello @Kielek